Dialog: fix incorrect updatePopper calls

f9b19d9a · Leopoldthecoder · 杨奕 · dfe8972e · f9b19d9a · f9b19d9a
Commit f9b19d9a authored Jun 07, 2017 by Leopoldthecoder Committed by 杨奕 Jun 09, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

packages/dropdown/src/dropdown-menu.vue packages/dropdown/src/dropdown-menu.vue +3 -1

packages/select/src/select-dropdown.vue packages/select/src/select-dropdown.vue +3 -1

No files found.
--- a/packages/dropdown/src/dropdown-menu.vue
+++ b/packages/dropdown/src/dropdown-menu.vue
@@ -16,7 +16,9 @@
    mixins: [Popper],

    created() {
-      this.$on('updatePopper', this.updatePopper);
+      this.$on('updatePopper', () => {
+        if (this.showPopper) this.updatePopper();
+      });
      this.$on('visible', val => {
        this.showPopper = val;
      });

--- a/packages/select/src/select-dropdown.vue
+++ b/packages/select/src/select-dropdown.vue
@@ -57,7 +57,9 @@
    mounted() {
      this.referenceElm = this.$parent.$refs.reference.$el;
      this.$parent.popperElm = this.popperElm = this.$el;
-      this.$on('updatePopper', this.updatePopper);
+      this.$on('updatePopper', () => {
+        if (this.$parent.visible) this.updatePopper();
+      });
      this.$on('destroyPopper', this.destroyPopper);
    }
  };