Slider: fix a NaN value bug (#1286)

2e3ecd93 · 杨奕 · FuryBean · f729497d · 2e3ecd93
Commit 2e3ecd93 authored Nov 23, 2016 by 杨奕 Committed by FuryBean Nov 23, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

packages/slider/src/main.vue packages/slider/src/main.vue +4 -2

No files found.
--- a/packages/slider/src/main.vue
+++ b/packages/slider/src/main.vue
@@ -107,7 +107,7 @@
        this.$nextTick(() => {
          this.updatePopper();
        });
-        if (val < this.min) {
+        if (typeof val !== 'number' || isNaN(val) || val < this.min) {
          this.$emit('input', this.min);
          return;
        }
@@ -221,7 +221,9 @@
    },

    created() {
-      if (typeof this.value !== 'number' || this.value < this.min) {
+      if (typeof this.value !== 'number' ||
+        isNaN(this.value) ||
+        this.value < this.min) {
        this.$emit('input', this.min);
      } else if (this.value > this.max) {
        this.$emit('input', this.max);